Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6489: add menu context to menu #6488

Merged

Conversation

peconomou929
Copy link
Contributor

@peconomou929 peconomou929 commented Apr 27, 2024

As discussed here, adds a MenuContext to the Menu so that individual menu items can be customized via the Pass Through options, mirroring the behavior of the Tab Menu.

Can the maintainers take a look and open an issue for this feature?'

Fix #6489

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 6:06pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 6:06pm

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

I will take a look

@melloware melloware added the Status: Pending Test Issue or pull request is being tested by Core Team label Apr 28, 2024
@melloware melloware changed the title Feature: add menu context to menu Fix #6489: add menu context to menu Apr 29, 2024
@melloware melloware requested a review from nitrogenous April 29, 2024 14:28
@nitrogenous nitrogenous added this to the 10.6.4 milestone Apr 29, 2024
Copy link
Contributor

@nitrogenous nitrogenous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great PR

@nitrogenous nitrogenous merged commit a6973cf into primefaces:master Apr 30, 2024
6 of 7 checks passed
@nitrogenous nitrogenous removed this from the 10.6.4 milestone Apr 30, 2024
@peconomou929 peconomou929 deleted the feature/add-context-to-menu branch July 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Test Issue or pull request is being tested by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: include "context" in the PrimeReact Menu component
3 participants