-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:CascadeSelect missing some values in pt #5502
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
2 similar comments
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
@kl-nevermore @Dalorzo I think this is mixing up export interface CascadeSelectPassThroughMethodOptions {
props: CascadeSelectProps;
state: CascadeSelectState;
}
/**
* Defines current inline state in CascadeSelect component.
*/
export interface CascadeSelectState {
/**
* Current focused state as a boolean.
* @defaultValue false
*/
focused: boolean;
/**
* Current overlay visible state as a boolean.
* @defaultValue false
*/
overlayVisible: boolean;
/**
* Current overlay attributeSelector state as a string.
*/
attributeSelector: string;
} It looks like you are passing the same values that would go to |
I can't impl some styles in unstyled using pt if I can't get consistent values example
I referred to some comp like dropdown use ptm pass value to pt |
That is a good question. It seems CX and PTM are definitely treated differently I am not quite sure why. And yes the Types would have to be updated that is what @Dalorzo has been helping with. |
@kl-nevermore @Dalorzo see my PR fixing these issues: So for PTM you always have 3 objects export interface CascadeSelectPassThroughMethodOptions {
props: CascadeSelectProps;
state: CascadeSelectState;
context: CascadeSelectContext;
} So for your examples above in passthrough you will use.
'list and sublist |
Fix #5479