Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4934: Password keydown called twice #4935

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix #4934: Password keydown called twice #4935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/lib/blockui/__snapshots__/BlockUI.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ exports[`BlockUI container style and className 1`] = `
</div>
</div>
<div
class="p-blockui p-component-overlay p-component-overlay-enter block-jest"
class="block-jest p-blockui p-component-overlay p-component-overlay-enter"
data-pc-section="mask"
style="cursor: move; position: absolute; top: 0px; left: 0px; width: 100%; height: 100%; z-index: 4205;"
/>
Expand Down
1 change: 0 additions & 1 deletion components/lib/password/Password.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ export const Password = React.memo(
className: cx('root', { isFilled, focusedState }),
style: props.style
},
PasswordBase.getOtherProps(props),
ptm('root')
);

Expand Down
2 changes: 1 addition & 1 deletion components/lib/password/PasswordBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const PasswordBase = ComponentBase.extend({
panelClassName: null,
transitionOptions: null,
tabIndex: null,
value: null,
value: undefined,
onInput: null,
onShow: null,
onHide: null,
Expand Down
24 changes: 12 additions & 12 deletions components/lib/splitter/__snapshots__/Splitter.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`Splitter Nested 1`] = `
>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(20% - 4px);"
Expand All @@ -29,7 +29,7 @@ exports[`Splitter Nested 1`] = `
</div>
<div
class="p-splitter-panel p-splitter-panel-nested"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(80% - 4px);"
Expand All @@ -41,7 +41,7 @@ exports[`Splitter Nested 1`] = `
>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(15% - 4px);"
Expand All @@ -60,7 +60,7 @@ exports[`Splitter Nested 1`] = `
</div>
<div
class="p-splitter-panel p-splitter-panel-nested"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(85% - 4px);"
Expand All @@ -72,7 +72,7 @@ exports[`Splitter Nested 1`] = `
>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(20% - 4px);"
Expand All @@ -91,7 +91,7 @@ exports[`Splitter Nested 1`] = `
</div>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(80% - 4px);"
Expand All @@ -116,7 +116,7 @@ exports[`Splitter Single Panel with size 1`] = `
>
<div
class="p-splitter-panel"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(5% - 0px);"
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`Splitter Single Panel without size 1`] = `
>
<div
class="p-splitter-panel"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(100% - 0px);"
Expand Down Expand Up @@ -178,7 +178,7 @@ exports[`Splitter Splitter requires two SplitterPanel components to wrap. 1`] =
>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(50% - 4px);"
Expand All @@ -197,7 +197,7 @@ exports[`Splitter Splitter requires two SplitterPanel components to wrap. 1`] =
</div>
<div
class="p-splitter-panel flex align-items-center justify-content-center"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(50% - 4px);"
Expand All @@ -218,7 +218,7 @@ exports[`Splitter Vertical layout 1`] = `
>
<div
class="p-splitter-panel"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(50% - 4px);"
Expand All @@ -237,7 +237,7 @@ exports[`Splitter Vertical layout 1`] = `
</div>
<div
class="p-splitter-panel"
data-pc-name="splitter"
data-pc-name=""
data-pc-section="root"
role="presentation"
style="flex-basis: calc(50% - 4px);"
Expand Down