Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: hideDelay no longer working in 10.9.2 #7687

Closed
ktdd opened this issue Feb 9, 2025 · 6 comments · Fixed by #7688
Closed

Tooltip: hideDelay no longer working in 10.9.2 #7687

ktdd opened this issue Feb 9, 2025 · 6 comments · Fixed by #7688
Assignees
@andreev-artem
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.9.3

Comments

@ktdd
Copy link

ktdd commented Feb 9, 2025

Describe the bug

hideDelay worked fine in 10.9.1 but after updating to 10.9.2 it no longer does nothing.

I'm pretty sure it's because setVisibleState needs to be inside applyDelay's callback and that was removed in 10.9.2.

Reproducer

No response

System Information

Not needed

Steps to reproduce the behavior

No response

Expected behavior

No response
@ktdd ktdd added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 9, 2025
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 9, 2025
@melloware
Copy link
Member

@andreev-artem it looks like #7590 broke this?

@melloware
Copy link
Member

@ktdd do you have a fix? Want to submit a PR?

@ktdd
Copy link
Author

ktdd commented Feb 9, 2025

I moved setVisibleState back where it was in previous version and it's working for the time being. As for the original bug report regarding stuck tooltips, I have no idea how to fix it off the top of my head. Let's see if @andreev-artem has more ideas.

@melloware
Copy link
Member

ok good idea @ktdd

andreev-artem pushed a commit to andreev-artem/primereact that referenced this issue Feb 9, 2025
Fix primefaces#7687: Tooltip - hideDelay no longer working in 10.9.2
954ac32
@andreev-artem andreev-artem mentioned this issue Feb 9, 2025
Merged
@andreev-artem
Copy link
Contributor

@melloware I've provided PR with a more accurate fix which should cover both bugs

@melloware melloware added this to the 10.9.3 milestone Feb 9, 2025
@melloware
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreev-artem andreev-artem

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.9.3
Development

Successfully merging a pull request may close this issue.

Fix #7687: Tooltip - hideDelay no longer working in 10.9.2 andreev-artem/primereact
3 participants
@andreev-artem @melloware @ktdd