Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Accessibility error reported in console on clicking any menu item #7045

Closed
mujahidislam opened this issue Aug 14, 2024 · 2 comments · Fixed by #7562
Closed

Menu: Accessibility error reported in console on clicking any menu item #7045

mujahidislam opened this issue Aug 14, 2024 · 2 comments · Fixed by #7562
Assignees
@melloware
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Milestone
10.9.2

Comments

@mujahidislam
Copy link

mujahidislam commented Aug 14, 2024 •
edited
Loading

Describe the bug

There is a "aria-hidden" attribute on anchor tag within menu item and whenever we click on it, browser console reports that the attribute is blocked as focusable elements must not be hidden from assistive technology users.

Reproducer

https://stackblitz.com/edit/vitejs-vite-km4s9u

System Information

node: 20.11.0
react: 18.2.0
primereact: 10.8.2

MS Edge Chromium

Steps to reproduce the behavior

  1. Open Developer tools
  2. Click on "New" or "Settings" menu items on the rendered page
  3. Console reports "Blocked aria-hidden on a element because the element that just received focus must not be hidden from assistive technology users."

Expected behavior

No console errors related to accessibility
@mujahidislam mujahidislam added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 14, 2024
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 14, 2024
@melloware
Copy link
Member

I will assign to PrimeTek as I am not sure why its aria-hidden but I can see that PrimeVue is the same way: https://primevue.org/menu/

melloware added a commit to melloware/primereact that referenced this issue Jan 3, 2025
@melloware
Fix primefaces#7045: MenuItem remove aria-hidden
6e7d844
@melloware melloware added this to the 10.9.2 milestone Jan 3, 2025
@melloware melloware assigned melloware and unassigned mertsincan and nitrogenous Jan 3, 2025
@melloware melloware mentioned this issue Jan 3, 2025
Merged
@melloware
Copy link
Member

I confirmed in PrimeVue aria-hidden is not there so removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA
Projects
None yet
Milestone
10.9.2
Development

Successfully merging a pull request may close this issue.

Fix #7045: MenuItem remove aria-hidden melloware/primereact
4 participants
@melloware @mertsincan @mujahidislam @nitrogenous