Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Advanced Column Filter 'Match Mode' Dropdowns Are Broken in 10.6.4 #6550

Closed
SolidAnonDev opened this issue May 2, 2024 · 3 comments · Fixed by #6551, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Closed

DataTable: Advanced Column Filter 'Match Mode' Dropdowns Are Broken in 10.6.4 #6550

SolidAnonDev opened this issue May 2, 2024 · 3 comments · Fixed by #6551, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Assignees
@Rekl0w
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.5

Comments

@SolidAnonDev
Copy link

SolidAnonDev commented May 2, 2024 •
edited
Loading

Describe the bug

The 'advanced' column filter dropdowns that generally holding match modes like "Contains" or "Starts With" cause a break in 10.6.4. You can actually just find this in the documentation itself, as the example linked below has the same issue my application had when 10.6.4 was installed.

Reproducer

https://primereact.org/datatable/#advanced_filter

PrimeReact version

10.6.4

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

  1. Access the link and if you aren't already there, you will find the issue directly in the 'Advanced Filtering' section of the documentation
  2. Open a column filter as designated by the filter icon, where one contains match modes, I recommend Name, Country, Date, or Balance
  3. Attempt to open the dropdowns for the match mode and you will see an unrecoverable client side error is thrown.

Expected behavior

You can open the column filter and select a match mode from the dropdown menu.

You will also notice they do not display a the currently selected value.
@SolidAnonDev SolidAnonDev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@SolidAnonDev SolidAnonDev changed the title DataTable: Advanced Filter Dropdowns Are Broken in 10.6.4 DataTable: Advanced Column Filter 'Match Mode' Dropdowns Are Broken in 10.6.4 May 2, 2024
@melloware
Copy link
Member

Duplicate of #6531

@melloware melloware marked this as a duplicate of #6531 May 2, 2024
@melloware melloware added Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 2, 2024
@melloware melloware added this to the 10.7.0 milestone May 2, 2024
@Rekl0w Rekl0w mentioned this issue May 2, 2024
Merged
@Rekl0w
Copy link
Contributor

Rekl0w commented May 2, 2024

PR submitted, it should work now.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Resolution: Duplicate Issue has already been reported or a pull request related to same issue has already been submitted labels May 2, 2024
melloware pushed a commit that referenced this issue May 2, 2024
@Rekl0w
Fix #6550: dropdown filter fix (#6551)
7312fe4 
* Fix #6550: dropdown filter fix

* Revert "Fix #6550: dropdown filter fix"

This reverts commit 1c45d79.

* Fix #6550: dropdown filter fix update

* Revert "Fix #6550: dropdown filter fix update"

This reverts commit e7b020e.

* Fix #6550: dropdown filter fix update
@melloware
Copy link
Member

Please try 10.6.5

@leoo1992 leoo1992 mentioned this issue May 24, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rekl0w Rekl0w

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.5
3 participants
@melloware @Rekl0w @SolidAnonDev