Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Problem with Dark Theme in Default column on Components API section #6125

Closed
ademarsj opened this issue Mar 9, 2024 · 0 comments · Fixed by #6126
Closed

Documentation: Problem with Dark Theme in Default column on Components API section #6125

ademarsj opened this issue Mar 9, 2024 · 0 comments · Fixed by #6126
Assignees
@ademarsj
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
10.5.2

Comments

@ademarsj
Copy link
Contributor

ademarsj commented Mar 9, 2024

Describe the bug

When I enable dark mode, the values of column "Default" on API section becomes unreadable.
I found that the elements still on light mode, I will submit a pull request.

PS: Sorry for poor english.

image

Reproducer

No response

PrimeReact version

10.5.1

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to any component documentation
  2. Go to "Api" section
  3. Enable dark mode

Expected behavior

The "Default" column values had to be readable.
@ademarsj ademarsj added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 9, 2024
@ademarsj ademarsj mentioned this issue Mar 9, 2024
Merged
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 9, 2024
@melloware melloware added this to the 10.5.2 milestone Mar 9, 2024
nitrogenous added a commit that referenced this issue Mar 18, 2024
@nitrogenous
Merge pull request #6126 from ademarsj/master
3f07e73 
fix: values of Default column in API section is  unreadable when darkMode (fixes #6125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ademarsj ademarsj

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
10.5.2
Development

Successfully merging a pull request may close this issue.

fix: values of Default column in API section is unreadable when darkMode (fixes #6125)
2 participants
@melloware @ademarsj