Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable Column Filter: Clear Button will not show if filter menu button is hidden #5802

Closed
cassenhp opened this issue Jan 18, 2024 · 1 comment · Fixed by #5803 or #5806
Closed

Datatable Column Filter: Clear Button will not show if filter menu button is hidden #5802

cassenhp opened this issue Jan 18, 2024 · 1 comment · Fixed by #5803 or #5806
Assignees
@cassenhp
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.4.0

Comments

@cassenhp
Copy link
Contributor

Describe the bug

In datatable, the clear filter button will now render unless filter button is also rendered

It appears that there may have been an erroneous change in this commit: deec2b2

Reproducer

https://stackblitz.com/edit/vqsqhi?file=src%2FApp.jsx

PrimeReact version

10.3.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Scroll down to the name column and see that showClearButton is set to true and showFilterMenu is false

Expected behavior

If showClearButton is set to true and showFilterMenu is false, the clear button should still show
@cassenhp cassenhp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 18, 2024
@cassenhp cassenhp changed the title Replace_With_Component_Name: Brief_Bug_Description Datatable Column Filter: Clear Button will not show if filter menu button is hidden Jan 18, 2024
@cassenhp cassenhp mentioned this issue Jan 18, 2024
Merged
cassenhp added a commit to cassenhp/primereact-filter-button-fix that referenced this issue Jan 18, 2024
@cassenhp
Merge pull request #1 from cassenhp/cassenhp-patch-1
85a85ca 
Update ColumnFilter.js to allow clear button to show when menu button… issue primefaces#5802
@cassenhp cassenhp mentioned this issue Jan 18, 2024
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 19, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 19, 2024
@melloware
Copy link
Member

Some changes requested on the PR

melloware added a commit to melloware/primereact that referenced this issue Jan 19, 2024
@melloware
Fix primefaces#5802: ShowClearButton consistency
356e383
@melloware melloware mentioned this issue Jan 19, 2024
Merged
melloware added a commit that referenced this issue Jan 19, 2024
@melloware
Fix #5802: ShowClearButton consistency (#5806)
51f94d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cassenhp cassenhp

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.4.0
2 participants
@melloware @cassenhp