Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.0.7: forwardRef Warning #5172

Closed
kabalan-datapostie opened this issue Oct 27, 2023 · 3 comments · Fixed by #5175
Closed

10.0.7: forwardRef Warning #5172

kabalan-datapostie opened this issue Oct 27, 2023 · 3 comments · Fixed by #5175
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.8

Comments

@kabalan-datapostie
Copy link

Describe the bug

Since upgrading to 10.0.7 I am getting the warning: Warning: forwardRef render functions accept exactly two parameters: props and ref. Did you forget to use the ref parameter?

This warning disappears when I revert back to 10.0.5. I am also able to reproduce it for 10.0.7 (see console in reproducer)

Showing up on CRA and Next.js

Reproducer

https://codesandbox.io/s/primereact-demo-forked-2tf8kn?file=/src/App.js

PrimeReact version

10.0.7

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 118

Steps to reproduce the behavior

No response

Expected behavior

No response
@kabalan-datapostie kabalan-datapostie added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 27, 2023
@melloware
Copy link
Member

Yep I see it too.

@melloware melloware added this to the 10.0.8 milestone Oct 27, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 27, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 27, 2023
@melloware
Fix primefaces#5172: Ripple forwardRef issue
3f1cc77
@melloware melloware mentioned this issue Oct 27, 2023
Merged
@melloware melloware self-assigned this Oct 27, 2023
melloware added a commit that referenced this issue Oct 27, 2023
@melloware
Fix #5172: Ripple forwardRef issue (#5175)
fdfc75f
@SoyDiego
Copy link
Contributor

Good, I came to report same issue. Thanks @melloware for the PR :)

@kabalan-datapostie
Copy link
Author

Confirming this is fixed as of 10.0.9 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.8
Development

Successfully merging a pull request may close this issue.

Fix #5172: Ripple forwardRef issue melloware/primereact
3 participants
@melloware @SoyDiego @kabalan-datapostie