Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password with ability to toggle mask via a method and a unmasked property #5135

Closed
noisypebble opened this issue Oct 21, 2023 · 0 comments · Fixed by #5136
Closed

Password with ability to toggle mask via a method and a unmasked property #5135

noisypebble opened this issue Oct 21, 2023 · 0 comments · Fixed by #5136
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@noisypebble
Copy link

noisypebble commented Oct 21, 2023

Describe the feature you would like to see added

Add it so you could then control the mask outside with a ref like:

passwordRef.current?.toggleMask();

and with a property like:

const [unmasked, setUnmasked] = useState(false);

<Password unmasked={unmasked} />

Much the way the disabled property works on Input components.

Is your feature request related to a problem?

There is no good way to programmatically control the masked/unmasked state of the Password component.

Describe the solution you'd like

A method to toggleMask from a ref to a Password component and an unmasked property that sets the state.

Describe alternatives you have considered

No response

Additional context

No response

@noisypebble noisypebble added Status: Discussion Issue or pull request needs to be discussed by Core Team Type: New Feature Issue contains a new feature or new component request labels Oct 21, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 21, 2023
@melloware melloware removed Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 21, 2023
@melloware melloware self-assigned this Oct 21, 2023
@melloware melloware added this to the 10.0.6 milestone Oct 21, 2023
melloware added a commit to melloware/primereact that referenced this issue Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants