Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete forceSelection causes error #4724

Closed
AuthorProxy opened this issue Aug 2, 2023 · 1 comment · Fixed by #4741
Closed

Autocomplete forceSelection causes error #4724

AuthorProxy opened this issue Aug 2, 2023 · 1 comment · Fixed by #4741
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.0.0

Comments

@AuthorProxy
Copy link

Describe the bug

BSOD: value.trim is not a function

Reproducer

https://codesandbox.io/s/primereact-demo-forked-g8rsff?file=/src/App.js

PrimeReact version

9.6.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. uncomment for
  2. try to select something

Expected behavior

no errors
@AuthorProxy AuthorProxy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 2, 2023
@melloware melloware self-assigned this Aug 4, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 4, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 4, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 4, 2023
@melloware
Fix primefaces#4724: Autocomplete prevent error on trim()
c7b432f
@melloware melloware mentioned this issue Aug 4, 2023
Merged
@melloware
Copy link
Member

BSOD! That is classic. I found and fixed the error it was always assuming a string when the value might not be a string.

melloware added a commit that referenced this issue Aug 4, 2023
@melloware
Fix #4724: Autocomplete prevent error on trim() (#4741)
e695965
@melloware melloware modified the milestones: 10.0.0, 9.7.0 Aug 22, 2023
@melloware melloware modified the milestones: 9.7.0, 10.0.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #4724: Autocomplete prevent error on trim() melloware/primereact
2 participants
@AuthorProxy @melloware