Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: Value does not update on external change #3515

Closed
harrybradshaw opened this issue Oct 28, 2022 · 1 comment · Fixed by #3517
Closed

Calendar: Value does not update on external change #3515

harrybradshaw opened this issue Oct 28, 2022 · 1 comment · Fixed by #3517
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.1

Comments

@harrybradshaw
Copy link
Contributor

Describe the bug

Changing the date via external means, e.g. a button, does not result in an instant update of the value shown. Only on opening and closing the pop-out does the value update.

A definite regression of the latest changes made from 8.6.0->8.7.0.

Reproducer

https://codesandbox.io/s/focused-cloud-3w73if?file=/src/demo/CalendarDemo.js

PrimeReact version

8.7.0

React version

17.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Click button labeled '2023-11-01'.
  2. Header and state updates, calendar value shown does not.
  3. Open and close popout to see update.

Expected behavior

Value shown should instantly update, as in previous version (8.6.0).
@harrybradshaw harrybradshaw added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 28, 2022
@melloware
Copy link
Member

Introduced with this fix: #3484

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 28, 2022
@melloware melloware self-assigned this Oct 28, 2022
@melloware melloware added this to the 8.7.1 milestone Oct 28, 2022
melloware added a commit to melloware/primereact that referenced this issue Oct 28, 2022
@melloware
Fix primefaces#3515: Calendar fix controlled value change
7c3f611
@melloware melloware mentioned this issue Oct 28, 2022
Merged
melloware added a commit to melloware/primereact that referenced this issue Oct 28, 2022
@melloware
Fix primefaces#3515: Calendar fix controlled value change
20fd559
melloware added a commit that referenced this issue Oct 28, 2022
@melloware
Fix #3515: Calendar fix controlled value change (#3517)
cc6d531
@KumJungMin KumJungMin mentioned this issue Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.1
2 participants
@melloware @harrybradshaw