Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optionValue to dropdown, multiselect, listbox and selectButton #7279

Closed
wants to merge 1 commit into from

Conversation

yelhouti
Copy link
Contributor

###Defect Fixes
When submitting a PR, please also create an issue documenting the error.

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
As you can see this a very minor change 6 lines if you don't include documentation, please accept it :)

@cagataycivici
Copy link
Member

Thank you but a feature of this size should be implemented by the team internally. For example, I don't see any tests in the PR.

@yelhouti
Copy link
Contributor Author

@cagataycivici I didn't add some because i didn't find any for optionLabel (maybe I didn't check enough), I would gladly add them if it means the PR would be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants