-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility | TabView - TabIndex order doesn't follow the W3C recommended pattern #13421
Labels
Component: Accessibility
Issue or pull request is related to WCAG or ARIA
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
Comments
GiacomoDM
added a commit
to GiacomoDM/primeng
that referenced
this issue
Aug 2, 2023
Is GitHub's tab interface working the same way as PrimeNG? GitHubTabs.mov |
You are right, but the HTML structure of GitHub's page doesn't have the These roles tells the screen reader that the element's behaviour is the Tab view's one, for which there is the recommended W3C pattern. |
GiacomoDM
added a commit
to GiacomoDM/primeng
that referenced
this issue
Aug 7, 2023
This reverts commit d4524de.
cetincakiroglu
added a commit
that referenced
this issue
Aug 10, 2023
Bugfix/#13421 tabview accessibility fixes
cetincakiroglu
added a commit
that referenced
this issue
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Accessibility
Issue or pull request is related to WCAG or ARIA
Type: Enhancement
Issue contains an enhancement related to a specific component. Additional functionality has been add
Describe the bug
As stated in the W3C Authoring Practices Guide, for a Tab interface the
tab
button should behave as follow:Check: https://www.w3.org/WAI/ARIA/apg/patterns/tabs/#keyboardinteraction for reference.
To be compliant with WCAG, all the patterns should be applied.
Environment
Windows
Reproducer
https://primeng.org/tabview
Angular version
16.X
PrimeNG version
16.1.0
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
16.20
Browser(s)
No response
Steps to reproduce the behavior
tab
Expected behavior
Pressing
tab
, the focus should move inside the content of the selected tab, if focusable, or to the next focusable element of the page.The text was updated successfully, but these errors were encountered: