Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Carousel add better playing status support #12706

Closed
EnricoMessall opened this issue Mar 4, 2023 · 1 comment · Fixed by #12816
Closed

Component: Carousel add better playing status support #12706

EnricoMessall opened this issue Mar 4, 2023 · 1 comment · Fixed by #12816
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.3.0

Comments

@EnricoMessall
Copy link
Contributor

Describe the feature you would like to see added

At the moment the interval variable is still set after using clearInterval and therefor it is not that good to identify if the carousel is having a interval or not.

This ticket adds ability to get if the carousel is moving by the value "playing" or the method "isPlaying" updating its state by the startAutoplay and stopAutoplay Methods

Is your feature request related to a problem?

No response

Describe the solution you'd like

No response

Describe alternatives you have considered

No response

Additional context

No response
@EnricoMessall EnricoMessall added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Mar 4, 2023
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 4, 2023
@EnricoMessall
Issue primefaces#12706
d6dea21 
 + Is Playing Status
@EnricoMessall EnricoMessall changed the title Component: Carousel Component: Carousel add better playing status support Mar 4, 2023
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 4, 2023
@EnricoMessall
Issue primefaces#12706
86b10dc 
 + Fixed Allow Autoplay Behaviour
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 10, 2023
@EnricoMessall
Revert "Issue primefaces#12706"
5d465d8 
This reverts commit 86b10dc.
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 10, 2023
@EnricoMessall
Revert "Issue primefaces#12706"
8d02b79 
This reverts commit d6dea21.
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 11, 2023
@EnricoMessall
Issue primefaces#12706
def3b0a 
 + Made isPlaying a clear boolean method
@EnricoMessall EnricoMessall mentioned this issue Mar 25, 2023
Merged
EnricoMessall added a commit to Arematics/primeng that referenced this issue Mar 25, 2023
@EnricoMessall
Issue primefaces#12706
d598f5e 
 + Fixed Prettier for Carousel
@EnricoMessall
Copy link
Contributor Author

EnricoMessall commented May 9, 2023 •
edited
Loading

@cetincakiroglu Hey. Is it possible to have a look on this one? The new feature is only the isPlaying Method and everything else is more or less a bug fix when stopping autoplay. Would be nice to include this since i'm using a weird kind of primeng into my own application mix only for this :D

mertsincan pushed a commit that referenced this issue Aug 18, 2023
@EnricoMessall
Fixed #12706 - added isPlaying State and fixed usage of start- and st…
21c9c41 
…opAutoplay from outside of the component (#12816)

* Issue #12706
 + Made isPlaying a clear boolean method

* Issue #12706
 + Fixed Prettier for Carousel
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 18, 2023
@gucal gucal added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Issue's fix will be ported to supported LTS versions Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.3.0
3 participants
@mertsincan @gucal @EnricoMessall