Fixed #10866 - readonly not working on p-inputNumber

primefaces · Nov 22, 2021 · 4f32ed6 · 4f32ed6
1 parent 00d8955
commit 4f32ed6
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/app/components/inputnumber/inputnumber.ts b/src/app/components/inputnumber/inputnumber.ts
@@ -414,13 +414,21 @@ export class InputNumber implements OnInit,ControlValueAccessor {
     }
 
     onUserInput(event) {
+        if(this.readonly) {
+            return;
+        }
+
         if (this.isSpecialChar) {
             event.target.value = this.lastValue;
         }
         this.isSpecialChar = false;
     }
 
     onInputKeyDown(event) {
+        if(this.readonly) {
+            return;
+        }
+
         this.lastValue = event.target.value;
         if (event.shiftKey || event.altKey) {
             this.isSpecialChar = true;
@@ -573,6 +581,10 @@ export class InputNumber implements OnInit,ControlValueAccessor {
     }
 
     onInputKeyPress(event) {
+        if (this.readonly) {
+            return;
+        }
+
         event.preventDefault();
         let code = event.which || event.keyCode;
         let char = String.fromCharCode(code);
@@ -585,7 +597,7 @@ export class InputNumber implements OnInit,ControlValueAccessor {
     }
 
     onPaste(event) {
-        if (!this.disabled) {
+        if (!this.disabled && !this.readonly) {
             event.preventDefault();
             let data = (event.clipboardData || window['clipboardData']).getData('Text');
             if (data) {
@@ -793,7 +805,9 @@ export class InputNumber implements OnInit,ControlValueAccessor {
     }
 
     onInputClick() {
-        this.initCursor();
+        if(!this.readonly) {
+            this.initCursor();
+        }
     }
 
     isNumeralChar(char) {

diff --git a/src/app/showcase/components/inputnumber/inputnumberdemo.ts b/src/app/showcase/components/inputnumber/inputnumberdemo.ts
@@ -44,4 +44,4 @@ export class InputNumberDemo {
     value19: number = 25;
 
     value20: number = 50;
-}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,4 +44,4 @@ export class InputNumberDemo { @@
         value19: number = 25;
         value20: number = 50;
-    }
+    }