Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade husky to v8 #801

Merged
merged 1 commit into from
Dec 15, 2022
Merged

chore: upgrade husky to v8 #801

merged 1 commit into from
Dec 15, 2022

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Oct 13, 2022

fixes #746

Getting rid old really old transitive husky@2 dependencies.

Husky v8:

  • Zero dependencies and lightweight (6 kB)
  • Powered by modern new Git feature (core.hooksPath)
  • Follows npm and Yarn best practices regarding autoinstall

opt-cli seems to be abandoned (last update 5 years ago).
Looks like this dependency is not needed anymore with the new Husky. (couldn't find other references/usage in the project)

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

⚠️ No Changeset found

Latest commit: 55bad9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -5,9 +5,9 @@
"main": "dist/index.js",
"types": "types/index.d.ts",
"scripts": {
"prepare": "husky install",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why husky doesn't autoinstall anymore

https://blog.typicode.com/husky-git-hooks-autoinstall/

@idahogurl idahogurl merged commit 9fe4165 into prettier:master Dec 15, 2022
@chimurai chimurai deleted the husky-upgrade branch December 17, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants