-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition plan for new requirePragma
in prettier core
#54
Comments
Closed
I think we could probably deprecate the pragma option in |
Closed
BPScott
added a commit
that referenced
this issue
Sep 27, 2018
Merged
BPScott
added a commit
that referenced
this issue
Sep 27, 2018
Closed as pragma functionality has been removed in favour of using prettier's native pragma support as of v3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just got the pragma functionality merged into prettier itself at prettier/prettier#2772. It is very similar to the functionality implemented here, only:
@prettier
or@format
. There's a bit of discussion in that PR behind this reasoning.How should we manage the transition from
eslint-plugin-prettier
's implementation of pragmas to the new one in core? Off the top of my head it makes sense to no longer use the third option for this plugin, and instead either rely on a.prettierrc
or instruct users to pass alongrequirePragma
in the second options argument of this plugin.Thanks! cc @asuarez
The text was updated successfully, but these errors were encountered: