Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition plan for new requirePragma in prettier core #54

Closed
wbinnssmith opened this issue Sep 13, 2017 · 2 comments
Closed

Transition plan for new requirePragma in prettier core #54

wbinnssmith opened this issue Sep 13, 2017 · 2 comments

Comments

@wbinnssmith
Copy link

wbinnssmith commented Sep 13, 2017

I just got the pragma functionality merged into prettier itself at prettier/prettier#2772. It is very similar to the functionality implemented here, only:

  • Now editors can use their autoformat functionality and follow the same rules for applying based on the pragma as other tools
  • The name of the pragma is fixed to either @prettier or @format. There's a bit of discussion in that PR behind this reasoning.

How should we manage the transition from eslint-plugin-prettier's implementation of pragmas to the new one in core? Off the top of my head it makes sense to no longer use the third option for this plugin, and instead either rely on a .prettierrc or instruct users to pass along requirePragma in the second options argument of this plugin.

Thanks! cc @asuarez

@not-an-aardvark
Copy link
Member

I think we could probably deprecate the pragma option in eslint-plugin-prettier in favor of using prettier's version directly. People won't be able to use pragmas other than @prettier or @format, but my impression is that being able to customize the pragma isn't a very important feature.

BPScott added a commit that referenced this issue Sep 27, 2018
Prettier now provides native pragma support using @Format or @prettier
notation. Use that instead of our implementation

Fixes #48, Fixes #54
@BPScott BPScott mentioned this issue Sep 27, 2018
Merged
BPScott added a commit that referenced this issue Sep 27, 2018
Prettier now provides native pragma support using @Format or @prettier
notation. Use that instead of our implementation

Fixes #48, Fixes #54
@BPScott
Copy link
Member

BPScott commented Oct 1, 2018

Closed as pragma functionality has been removed in favour of using prettier's native pragma support as of v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants