CI: Lint & Test #470
CI: Lint & Test #470
Conversation
.github/workflows/CI.yml
Outdated
| steps: | ||
| - uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 10 |
There was a problem hiding this comment.
shall we use node 12 for this?
There was a problem hiding this comment.
I copied this from the hardhat repo, we can modify it if you want. For reference:
- Node 10 will reach end of life in the coming weeks
- Node 11 and 13 are not maintained anymore
- Node 15 reaches end of life on June 1st
.github/workflows/CI.yml
Outdated
| run: npm run test:all | ||
|
|
||
| test_macos: | ||
| name: Test on MacOS with Node 10 |
There was a problem hiding this comment.
can we use Node 12 here too?
.github/workflows/CI.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| node: [10, 12, 14, 15] |
There was a problem hiding this comment.
I would just target 12, 14, and 15
.github/workflows/CI.yml
Outdated
| with: | ||
| path: | | ||
| node_modules | ||
| key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('package-lock.json') }} |
There was a problem hiding this comment.
I do not see any matrix.node above
| with: | ||
| path: | | ||
| node_modules | ||
| key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('package-lock.json') }} |
There was a problem hiding this comment.
I do not see any matrix.node above
.github/workflows/CI.yml
Outdated
| with: | ||
| path: | | ||
| node_modules | ||
| key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('package-lock.json') }} |
There was a problem hiding this comment.
this matrix.node here makes sense to me
.github/workflows/CI.yml
Outdated
| - name: install vyper | ||
| run: docker pull ethereum/vyper:0.1.0b10 |
There was a problem hiding this comment.
why do we need this docker image?
There was a problem hiding this comment.
Oops, error from the copy-paste.
|
Fixed the remaining points. @mattiaerre feel free to merge if you want! |
|
thanks @fvictorio I'll merge and publish a new version of the plugin right after |
Also: upgrade
solidity-comments-extractor