Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keeping prettier-comments files as close to the source #466

Merged
merged 1 commit into from
Apr 8, 2021
Merged

keeping prettier-comments files as close to the source #466

merged 1 commit into from
Apr 8, 2021

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Apr 6, 2021

Just moving back the responsibility of printing the unicode keyword to the solidity printer and not to the files taken from the prettier utils.

@Janther Janther requested review from fvictorio and mattiaerre April 6, 2021 10:18
@Janther Janther added the refactor reorganising the code without changes label Apr 7, 2021
mattiaerre
mattiaerre approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@mattiaerre mattiaerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great a "real" refactoring w/ no test changes 💪

@Janther Janther merged commit 9f8e549 into master Apr 8, 2021
@Janther Janther deleted the isUnicode branch April 8, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiaerre mattiaerre mattiaerre approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees
No one assigned
Labels
refactor reorganising the code without changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janther @mattiaerre