Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve assembly functions without return values #306

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Improve assembly functions without return values #306

merged 1 commit into from
Jul 28, 2020

Conversation

fvictorio
Copy link
Member

Closes #305.

@fvictorio fvictorio requested review from Janther and mattiaerre July 27, 2020 13:24
@codecov
Copy link

codecov bot commented Jul 27, 2020 •
edited
Loading

Codecov Report

Merging #306 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          88       88           
  Lines         689      689           
  Branches      129      129           
=======================================
  Hits          687      687           
  Misses          2        2
Impacted Files Coverage Δ
src/nodes/AssemblyFunctionDefinition.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ba1f0...17f1379. Read the comment docs.

mattiaerre
mattiaerre approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@mattiaerre mattiaerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fvictorio fvictorio merged commit 91ed5cb into master Jul 28, 2020
@fvictorio fvictorio deleted the assembly-func-definition branch July 28, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiaerre mattiaerre mattiaerre approved these changes

@Janther Janther Awaiting requested review from Janther

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssemblyFunctionDefinition is not entirely correct
2 participants
@fvictorio @mattiaerre