Resolve GBC vs. CGB mismash #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannye
reviewed
Jan 30, 2025
dannye
approved these changes
Jan 30, 2025
|
Since GBC is used by people in the average discussion of GBC, could we use that? I feel it is easier to read/understand. I know in hardware terms such as the labels on the back of the gameboy it will say CGB-001 and such, but people generally call it a GBC when abbreviated. Shouldn't we stick to what is the most commonly used abbreviated name for the system? |
Rangi42
reviewed
Jan 30, 2025
Rangi42
reviewed
Jan 30, 2025
Rangi42
requested changes
Jan 30, 2025
Rangi42
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are used so I went with
CGBoverGBC. The latter only remains for the.gbcfile extension.