Correct wTileMapBackup declared space #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
Jan 23, 2025
Engezerstorung
force-pushed
the
master
branch
from
c5b6f33 to
5d109b2
Compare
Rangi42
requested changes
Jan 24, 2025
Engezerstorung
force-pushed
the
master
branch
from
5d109b2 to
ab0beed
Compare
wTileMapBackup isnt just used to backup the tilemap but also as a buffer for a screen view out of blocks during the drawing of the tilemap, define a new union reflecting that. Add map gfx values in gfx_constants.asm. Edit overworld.asm to replace hardcoded values with new constants.
Engezerstorung
force-pushed
the
master
branch
from
ab0beed to
3a856c5
Compare
Rangi42
approved these changes
Jan 28, 2025
Rangi42
approved these changes
Jan 28, 2025
|
Neat, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wTileMapBackup isnt just used to backup the tilemap but also as a buffer for a screen view out of blocks during the drawing of the tilemap
i just changed the ds value but a new union with its own label could also be an idea
maybe also some more constants like in crystal, those values being used in LoadCurrentMapView
constants from crystal :
DEF METATILE_WIDTH EQU 4 ; tiles
DEF SCREEN_META_WIDTH EQU 6 ; metatiles
DEF SCREEN_META_HEIGHT EQU 5 ; metatiles
DEF SURROUNDING_WIDTH EQU SCREEN_META_WIDTH * METATILE_WIDTH ; tiles
DEF SURROUNDING_HEIGHT EQU SCREEN_META_HEIGHT * METATILE_WIDTH ; tiles
DEF MAP_CONNECTION_PADDING_WIDTH EQU 3 ; metatiles