Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up item comments #443

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Clean up item comments #443

merged 1 commit into from
Dec 19, 2023

Conversation

SatoMew
Copy link
Contributor

@SatoMew SatoMew commented Dec 17, 2023

This is basically a rehash of #424 with the feedback incorporated.

Rangi42
Rangi42 reviewed Dec 17, 2023
View reviewed changes
home/item.asm Outdated Show resolved Hide resolved
@Rangi42
Copy link
Member

Rangi42 commented Dec 17, 2023

Some good catches here. Thank you! @dannye I'll leave this to you?

dannye
dannye approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@dannye dannye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dannye dannye merged commit 07cefd4 into pret:master Dec 19, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2023
@dannye
Clean up item comments (#443)
dd01313
@SatoMew SatoMew deleted the unit branch December 19, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rangi42 Rangi42 Rangi42 left review comments

@dannye dannye dannye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SatoMew @Rangi42 @dannye