Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging formatted prepared query #15987

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

shixuan-fan
Copy link
Contributor

@shixuan-fan shixuan-fan commented Apr 22, 2021

Logging prepared query is useful especially for EXECUTE queries
as it could make debugging easier.

Test plan
Prepare query: prepare test from select * from orders where orderkey < ?;
Actual query: execute test using 100

Running in HiveQueryRunner with this session property enabled and disabled.
Screen Shot 2021-04-22 at 11 37 23 AM

== RELEASE NOTES ==

General Changes
* Add support for logging formatted prepared query. This could be enabled by setting session property ``log_formatted_query_enabled`` to ``true``.

@shixuan-fan shixuan-fan requested review from highker and a team April 22, 2021 18:39
@shixuan-fan shixuan-fan force-pushed the prepare branch 2 times, most recently from 78bcdec to c1fd7bc Compare April 22, 2021 19:04
@highker highker removed their assignment Apr 22, 2021
Logging prepared query is useful especially for EXECUTE queries
as it could make debugging easier.
@shixuan-fan shixuan-fan merged commit 24243ad into prestodb:master Apr 22, 2021
@shixuan-fan shixuan-fan deleted the prepare branch April 22, 2021 21:38
@vaishnavibatni vaishnavibatni mentioned this pull request Apr 27, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants