Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geometric distribution #15807

Closed
wants to merge 1 commit into from
Closed

Conversation

dowi
Copy link

@dowi dowi commented Mar 11, 2021

Test plan - (Please fill in how you tested your changes)

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.

Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==

General Changes
Added math functions for computing Geometric distribution's PMF and CDF
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 11, 2021

CLA Signed

The committers are authorized under a signed CLA.

  • ✅ Dovi Winberger (948b771a023fdb522c24033e0e32854f2f77d5ac, 416fc2821a694a4ea1cd77339060aec909fa657d, 969bf29d3f4158f9e72bd607b87b98b443fdb8fa, 1d30eec196a15c640ea93b02f48bd8a5e6ce1bdb)

@leepface
Copy link
Contributor

Code review:

  • squash commits together into one

@dowi
Copy link
Author

dowi commented Mar 16, 2021

Commits squashed

@talgalili
Copy link
Contributor

Hey @dowi - I see that this diff has merge conflicts, could you please resolve them?

@stale
Copy link

stale bot commented Mar 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

@stale stale bot added the stale label Mar 2, 2022
@stale stale bot closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants