#487 fix(storage): fix downloadURL error in file upload metadata #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,7 @@ | |||
| "redux-react-firebase" | |||
| ], | |||
| "dependencies": { | |||
| "@babel/polyfill": "^7.0.0", | |||
There was a problem hiding this comment.
Maybe that this addition was needed due to node version or babel-preset-env settings needing to be changed since it hasn't been needed until now? Not sure.
Either way though, we can leave it and we can investigate more before it goes to latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes errors I ran into when trying to save file metadata to Firestore on upload:
Async-related error: "ReferenceError: regeneratorRuntime is not defined" is fixed by installing babel/polyfill: Async functions producing an error "ReferenceError: regeneratorRuntime is not defined" babel/babel#5085
Syntax for returning
downloadURLfrom the fileMetadataFactory has changed; updated in docs.Also including a small fix to the 'Getting Started' docs, which I encountered when setting up a sample project to test.
Check List
If not relevant to pull request, check off as complete
(I did not add any tests, if needed please let me know.)
Relevant Issues
#480
#487
#488