Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

populatedDataToJS does not return null if the data endpoint is empty #50

Closed
DeividasK opened this issue Feb 1, 2017 · 4 comments
Closed

populatedDataToJS does not return null if the data endpoint is empty #50

DeividasK opened this issue Feb 1, 2017 · 4 comments
Assignees
@prescottprue
Labels
bug

Comments

@DeividasK
Copy link

I saw you've mentioned that populate will undergo a rewrite, but I just want to note that populatedDataToJS helper does not return null if the data endpoint is empty. It always returns undefined.
@prescottprue
Copy link
Owner

Going to try to replicate this to confirm, but if so that is not the intended functionality.

Thanks for noting!

@prescottprue prescottprue self-assigned this Feb 1, 2017
@prescottprue prescottprue mentioned this issue Feb 1, 2017
Merged
prescottprue added a commit that referenced this issue Feb 1, 2017
@prescottprue
Version v1.2.3 (#52)
8811cda 
* Population of list with items containing a child param that is Firebase list (`key: true`) using `populatedDataToJS` (#42)
* `populatedDataToJS` supports childParam option (#48)
* `populatedDataToJS` returns null for empty lists instead of `undefined` (#50)
* Unit tests added to cover all cases within `populatedDataToJS`
@prescottprue
Copy link
Owner

v1.2.3 should hopefully solve this issue, but I will leave it open until that is confirmed.

@prescottprue
Copy link
Owner

@DeividasK Have you been able to verify this fix?

@DeividasK
Copy link
Author

Sorry for such a long delay. Yes, I can verify that this works for me now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prescottprue prescottprue

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prescottprue @DeividasK