Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'Android' architecture from pre-vs2015 support #2419

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

redorav
Copy link
Collaborator

@redorav redorav commented Jan 14, 2025

What does this PR do?

Fixs issues when users set require(vstudio) in a script du to _ACTION not being set at the time of using
Android is not officially supported pre vs2015

Discussion about it here #2366

How does this PR change Premake's behavior?

Nothing that we might be worried about as support pre vs2015 was custom

Anything else we should know?

Add any other context about your changes here.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

It's not officially supported, and also is causing issues for overrides
@nickclark2016 nickclark2016 merged commit da8cacd into premake:master Jan 17, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants