Fix regression trying to use _ACTION in the global scope #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simpler than trying to add the proper fix as versions < 2015 don't support Android anyway
|
Seems it's failing some tests modified in the original PR now. I would suggest using the opportunity to also extend the unit tests by covering the override scenario from docs to avoid something similar in the future: https://premake.github.io/docs/Overrides-and-Call-Arrays/#introducing-overrides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a reported issue when calling require(vstudio) at the top of a file. Mentioned here #2366 (comment)
This is simpler than trying to add the proper fix as versions < 2015 don't support Android anyway
How does this PR change Premake's behavior?
Not really, vs2015 doesn't support Android natively
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!