Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token ordering for LINKFILE/LINKDIR #2400

Merged

Conversation

nickclark2016
Copy link
Member

@nickclark2016 nickclark2016 commented Dec 28, 2024

What does this PR do?

Fixes the ordering of LINKDIR and LINKFILE tokens to be consistent across platforms, selecting Windows semantics.

How does this PR change Premake's behavior?

Breaks anyone who used the API on Posix (should be a very small number, as the API was released since the last beta).

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team December 28, 2024 17:39
@nickclark2016 nickclark2016 merged commit d18a217 into premake:master Dec 28, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants