Bootstrap improvements #2291
Bootstrap improvements #2291
Conversation
|
All builds are passing however there is something going on with the CI report, the Windows expected checks are not turning green, I think due to me adding the Are those setup manually on the repo by any chance? Any idea @samsinsane? EDIT: Maybe it just looks at the current master workflow for those and it will be okay to merge as-is? |
|
I think it is related to #2279 Ping @samsinsane |
Bootstrap.bat
Outdated
| @@ -95,11 +106,11 @@ SET VsWhereCmdLine="!VsWherePath! -nologo -latest -version [%VsVersionMin%,%VsVe | |||
| FOR /F "usebackq delims=" %%i in (`!VsWhereCmdLine!`) DO ( | |||
|
|
|||
| IF EXIST "%%i\VC\Auxiliary\Build\vcvars32.bat" ( | |||
There was a problem hiding this comment.
I just realized the way this is chosen here probably affects the CI, previously it was hardcoded to x86_amd64 but now I think it will chose 32-bits.
There was a problem hiding this comment.
Wonder if we should just default or 64-bit or add one more parameter to the bat file? I'm pending towards just default to 64-bit builds?
There was a problem hiding this comment.
Updated PR with 64-bit build by default solution.
There was a problem hiding this comment.
I agree with this conclusion. 64 bit builds should be the default.
|
@tritao It looks like the statusing hung. Could you push up an empty commit to retrigger CI? |
I've already tried that on a previous PR, even tried opening a whole new PR (this is the second one I opened, due to trying to fix that issue). I think it must be due to some kind of manual setup that was done on Acttions settings? |
|
@tritao @Jarod42 @nickclark2016 CI checks have been updated. |
* Bootstrap improvements * Default to lookup 64-bit MSVC.
What does this PR do?
Adds a new
Bootstrap.shscript to simplify bootstrap in non-Windows platforms.Re-uses all the bootstrap scripts for CI to make sure they are well tested.
How does this PR change Premake's behavior?
I updated CI to use
vs2022asMSDEV. Previously we were usingvs2019, however if you pass that toBootstrap.batthenvswhere.execannot find VS.AFACT there is no point in forcing Premake to generate
vs2019files to build with MSVC 2022.So either we just pass an empty value so it auto detects latest MSVC, or pass it explicitly as part of a matrix as I've done.