Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display and change backend url from onboarding #341

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Janaka-Steph
Copy link
Contributor

@Janaka-Steph Janaka-Steph commented Aug 29, 2023

It closes #276
Display and change backend url from onboarding

Also catch error from checkIsServerRunning and return false so that handleCheckIsDockerRunning is not getting stuck. And make Check Again icon rotate to provide user feedback.

@what-the-diff
Copy link

what-the-diff bot commented Aug 29, 2023

PR Summary

  • Style Improvements to System Check Interface
    Improved the user interface of the system check page by adding new animations and styles such as for rotating the check icon. This contributes to a better user experience.

  • Introduction of BackendUrl Component
    A new component named BackendUrl was created. This component likely helps to specify or display the URL of the backend server during the onboarding process.

  • Updates to Dependency and System Check Components
    Made code changes to the Dependency and SystemCheck components. These changes probably enhance the way the system performs checks during the onboarding process.

  • Modification to Docker Check Functionality
    Made modifications to handle how the application checks whether Docker is running or not. Switched the return type of handleCheckIsDockerRunning function to Promise<void>, indicating a shift towards an asynchronous operation.

  • Improvements to Server Check Method
    Wrapped the code within checkIsServerRunning in utils.ts file inside a try-catch block. This reduces potential failures by gracefully handling errors when checking if the server is running.

  • Additional Colour Configurations in Tailwind CSS
    Introduced two new color configurations - ok and warning in Tailwind CSS file. This allows for more consistent styling and branding across the application.

@tiero
Copy link
Contributor

tiero commented Aug 29, 2023

utACK

@Janaka-Steph Janaka-Steph merged commit fa8114f into prem-research:main Aug 30, 2023
@Janaka-Steph Janaka-Steph deleted the backend-url-onboarding branch August 30, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Backend URL Caching on desktop app
2 participants