Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for redis gears trigger function commands #1348

Merged
merged 37 commits into from
Nov 1, 2023
Merged

Added support for redis gears trigger function commands #1348

merged 37 commits into from
Nov 1, 2023

Conversation

vladvildanov
Copy link
Contributor

No description provided.

@vladvildanov vladvildanov requested review from chayim and a team July 31, 2023 12:23
@vladvildanov vladvildanov requested a review from tillkruss as a code owner July 31, 2023 12:23
@vladvildanov vladvildanov force-pushed the vv-redis-gears-triggered-functions branch from 25d6427 to 1dba082 Compare July 31, 2023 12:31
@coveralls
Copy link

coveralls commented Jul 31, 2023 •
edited
Loading

Coverage Status

coverage: 82.431% (+0.1%) from 82.295% when pulling d09cd39 on vladvildanov:vv-redis-gears-triggered-functions into 2ae9af6 on predis:v3.x.

chayim
chayim reviewed Aug 1, 2023
View reviewed changes
chayim
chayim approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the conversation.

@vladvildanov vladvildanov force-pushed the vv-redis-gears-triggered-functions branch from 972a684 to a906514 Compare August 2, 2023 11:55
@vladvildanov vladvildanov requested a review from tillkruss August 2, 2023 13:16
@vladvildanov vladvildanov requested a review from tillkruss August 14, 2023 07:46
tillkruss
tillkruss requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add CHANGELOG entries as part of this PR?

@vladvildanov
Copy link
Contributor Author

@tillkruss Changelogs updated as separate PR for whole 3.0 update

#1393

@vladvildanov
Copy link
Contributor Author

@tillkruss Needs update on this, it's ready to merge

@vladvildanov vladvildanov mentioned this pull request Oct 23, 2023
Merged
@vladvildanov vladvildanov merged commit 662fdb9 into predis:v3.x Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss tillkruss approved these changes

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladvildanov @coveralls @tillkruss @chayim