Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 some necessary maintenance #80

Merged
merged 6 commits into from
Jan 18, 2023
Merged

🧹 some necessary maintenance #80

merged 6 commits into from
Jan 18, 2023

Conversation

jvdd
Copy link
Member

@jvdd jvdd commented Jan 18, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #80 (c3aa7af) into main (8ac5086) will not change coverage.
The diff coverage is 98.36%.

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          23       23           
  Lines        1245     1245           
=======================================
  Hits         1219     1219           
  Misses         26       26           
Impacted Files Coverage Δ
tsflex/processing/utils.py 74.19% <50.00%> (ø)
tsflex/__init__.py 100.00% <100.00%> (ø)
tsflex/chunking/__init__.py 100.00% <100.00%> (ø)
tsflex/chunking/chunking.py 98.07% <100.00%> (ø)
tsflex/features/feature.py 97.91% <100.00%> (ø)
tsflex/features/feature_collection.py 99.52% <100.00%> (ø)
tsflex/features/function_wrapper.py 100.00% <100.00%> (ø)
tsflex/features/integrations.py 98.48% <100.00%> (ø)
tsflex/features/logger.py 100.00% <100.00%> (ø)
tsflex/features/segmenter/strided_rolling.py 98.29% <100.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jvdd jvdd requested a review from jonasvdd January 18, 2023 13:29
@jvdd
Copy link
Member Author

jvdd commented Jan 18, 2023

Ready for review @jonasvdd

@jonasvdd
Copy link
Member

FYI @jvdd, the logger was only improved for the seriesprocessor (and thus not the FeatureCollection in #73 )

@jonasvdd
Copy link
Member

I will review it this evening! 😄

Copy link
Member

@jonasvdd jonasvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice cleanup!

@jonasvdd jonasvdd merged commit c681c9b into main Jan 18, 2023
@jvdd
Copy link
Member Author

jvdd commented Jan 18, 2023

@jonavdd what would you change to the logger of the FeatureCollection?

@jonasvdd
Copy link
Member

Maybe also show the duration in %, less mental effort to interpret the timings 😄 ? (as we did in #73)

@jvdd
Copy link
Member Author

jvdd commented Jan 18, 2023

Sure will look into it and submit a new PR!

@jvdd jvdd deleted the maintenance branch January 29, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 add formatting & linting checks to CI-CD
3 participants