[MRG] Remove deprecated closed argument in pd.daterange #64
Conversation
The `closed` argument was set to `None` which is the default, removing it should thus not have any impact. Since Pandas 1.4.0 this argument has been deprecated in favour of the `inclusive` argument so you get a lot of warnings when running the code. The default argument to `inclusive` is `"both"` which has the same behaviour as the current code. I thus see no need to add it. https://pandas.pydata.org/docs/reference/api/pandas.date_range.html
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 23 23
Lines 1103 1103
=======================================
Hits 1078 1078
Misses 25 25
Continue to review full report at Codecov.
|
|
Hi @jeroenboeye, Thanks for the contribution & clear description! 😄 Note: in #62 we fixed some bugs concerning the indexing of the extracted features. As soon as I find some time, I will look more into this branch and merge these improvements as well! As for now, I will release a new stable version that includes your improvement. |
|
Cool, you're welcome! |
|
(feel free to ⭐ this repo if you have'nt already 😄 ) |
The
closedargument was set toNonewhich is the default, removing it should thus not have any impact.Since Pandas 1.4.0 this argument has been deprecated in favour of the
inclusiveargument so you get a lot of warnings when running the code.The default argument to
inclusiveis"both"which has the same behaviour as the current code. I thus see no need to add it.https://pandas.pydata.org/docs/reference/api/pandas.date_range.html