Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐐 sorting output feature columns #41

Merged
merged 1 commit into from
Nov 16, 2021
Merged

🐐 sorting output feature columns #41

merged 1 commit into from
Nov 16, 2021

Conversation

jonasvdd
Copy link
Member

No description provided.

@jonasvdd jonasvdd requested a review from jvdd November 16, 2021 09:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #41 (bb03751) into main (1c6dc00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files          23       23           
  Lines        1007     1008    +1     
=======================================
+ Hits          980      981    +1     
  Misses         27       27
Impacted Files Coverage Δ
tsflex/features/feature_collection.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c6dc00...bb03751. Read the comment docs.

jvdd
jvdd approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jvdd jvdd merged commit c99265e into main Nov 16, 2021
@jonasvdd jonasvdd mentioned this pull request Nov 16, 2021
Closed
@jvdd jvdd deleted the sorted_feature_extraction branch December 12, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdd jvdd jvdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasvdd @codecov-commenter @jvdd