Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update antropy dependency + disable py 3.7 tests #108

Merged
merged 3 commits into from
Jul 29, 2023
Merged

⬆️ update antropy dependency + disable py 3.7 tests #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15ba8ef
:broom: remove deprecated antropy test on py3.11
jvdd Jul 29, 2023
357594b
:heavy_check_mark: disable python 3.7 tests for antropy
jvdd Jul 29, 2023
854571f
:pray:
jvdd Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ antropy = [
{ version = "^0.1.5", python = "<3.8" },
{ version = ">=0.1.6", python = ">=3.8" }
]
# antropy = { git = "https://github.com/raphaelvallat/antropy.git", branch = "master" } # replace with pip when > 0.1.5 release available
nolds = "^0.5.2"
pyentrp = [
{ version = "^0.7.1", python = "<3.8" },
Expand Down
16 changes: 5 additions & 11 deletions tests/test_features_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

__author__ = "Jeroen Van Der Donckt, Emiel Deprost, Jonas Van Der Donckt"


import sys

import numpy as np
Expand All @@ -20,10 +21,6 @@

from .utils import dummy_data

# import tsfresh
# import tsfel


## SEGLEARN


Expand Down Expand Up @@ -333,14 +330,11 @@ def test_catch22_all_features(dummy_data):

## ANTROPY


# With the current version that is used for Python 3.11, a small bug is present in the
# With the current version that is used for Python 3.7, a small bug is present in the
# source code of Antropy, which makes this test fail.
# Whilst we wait for a fix, we currently skip this test
# PR: https://github.com/raphaelvallat/antropy/pull/30
@pytest.mark.skipif(
sys.version_info >= (3, 11), reason="test disabled for Python 3.11 and higher."
)
# A fix for this bug is incuded in v0.1.6 of Antropy, but this version is not supported
# for Python 3.7.
@pytest.mark.skipif(sys.version_info < (3, 8), reason="test disabled for Python 3.7.")
def test_antropy_all_features(dummy_data):
# Tests if we integrate with ALL antropy features
# -> this requires no additional wrapper!
Expand Down