Refactoring functional tests #3657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
force-pushed
the
refactoring-functional-tests
branch
from
6ad3b09 to
26f38ea
Compare
osulzhenko
force-pushed
the
refactoring-functional-tests
branch
from
26f38ea to
c6ddf01
Compare
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/AmpFpdSpec.groovy
|
review is postponed |
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/module/AbTestingModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/GeneralModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/analyticstag/AnalyticsTagsModuleSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/ortb2blocking/Ortb2BlockingSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy # src/test/groovy/org/prebid/server/functional/tests/module/richmedia/RichMediaFilterSpec.groovy
# Conflicts: # src/test/groovy/org/prebid/server/functional/tests/privacy/ActivityTraceLogSpec.groovy
marki1an
requested changes
Feb 17, 2025
| @@ -7,15 +7,15 @@ import org.prebid.server.functional.util.PBSUtils | |||
| class UserExtData { | |||
|
|
|||
| List<String> keywords | |||
| String buyeruid | |||
| List<String> buyeruids | |||
| String buyerUid | |||
There was a problem hiding this comment.
Is it was changed in tech spec?
| @@ -15,12 +14,12 @@ import static org.prebid.server.functional.model.request.auction.FetchStatus.SUC | |||
| class AnalyticResult { | |||
|
|
|||
| String name | |||
| FetchStatus status | |||
| String status | |||
| @@ -42,6 +42,12 @@ abstract class BaseSpec extends Specification implements ObjectMapperWrapper { | |||
| private static final String DEFAULT_CACHE_DIRECTORY = "/app/prebid-server/data" | |||
| protected static final Map<String, String> GENERIC_ALIAS_CONFIG = ["adapters.generic.aliases.alias.enabled" : "true", | |||
| "adapters.generic.aliases.alias.endpoint": "$networkServiceContainer.rootUri/auction".toString()] | |||
| protected static final Map<String, String> EMPTY_CACHE_TTL_CONFIG = ["cache.default-ttl-seconds.banner": "", | |||
Comment on lines
28
to
32
| values() | ||
| .collect { [stage: it, matchLength: moduleHook.code.indexOf(it.value) >= 0 ? it.value.length() : -1] } | ||
| .findAll { it.matchLength > 0 } | ||
| .max { it.matchLength } | ||
| ?.stage |
There was a problem hiding this comment.
values().collect { [stage: it, matchLength: moduleHook.code.indexOf(it.value) >= 0 ? it.value.length() : -1] }
.findAll { it.matchLength > 0 }
.max { it.matchLength }
?.stage
| @@ -97,7 +97,8 @@ class CacheSpec extends BaseSpec { | |||
| def "PBS should cache bids without api-key header when targeting is specified and api-key-secured disabled"() { | |||
| given: "Pbs config with disabled api-key-secured and pbc.api.key" | |||
| def apiKey = PBSUtils.randomString | |||
| def pbsService = pbsServiceFactory.getService(['pbc.api.key': apiKey, 'cache.api-key-secured': 'false']) | |||
| def pbsConfig = ['pbc.api.key': apiKey, 'cache.api-key-secured': 'false'] | |||
There was a problem hiding this comment.
['pbc.api.key': apiKey,
'cache.api-key-secured': 'false']
Same for other
| ] | ||
|
|
||
| private static final PrebidServerService storedRequestIdGenEnabledService = pbsServiceFactory.getService(STORED_REQUEST_ID_GEN_ENABLED_CONFIG) | ||
|
|
There was a problem hiding this comment.
Please remove empty line
| ORTB_ADAPTER_CONFIG + | ||
| MODIFYING_VAST_CONFIG + | ||
| EXTERNAL_MODULES_CONFIG | ||
| ) | ||
| } | ||
|
|
||
| def cleanupSpec() { |
There was a problem hiding this comment.
What about cleanup pbsServiceWithMultipleModules container?
There was a problem hiding this comment.
This is a base module, meaning it will clean up after the package, and with cleanupSpec, it will drop and restart the container every time. And this is not efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check