-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greenbids: Add account level config for modules RTD, analytics #3596
Merged
CTMBNara
merged 13 commits into
prebid:master
from
EvgeniiMunin:greenbids-rtd-account-level-config
Feb 5, 2025
Merged
Greenbids: Add account level config for modules RTD, analytics #3596
CTMBNara
merged 13 commits into
prebid:master
from
EvgeniiMunin:greenbids-rtd-account-level-config
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Dec 12, 2024
...ks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/model/data/Partner.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java
Show resolved
Hide resolved
21 tasks
Depends on PR: #3596 |
@EvgeniiMunin fix was merged, this PR should be unlocked |
9216dfd
to
f155ee3
Compare
AntoxaAntoxic
requested changes
Jan 23, 2025
...rg/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java
Outdated
Show resolved
Hide resolved
...ks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Jan 27, 2025
...rg/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java
Outdated
Show resolved
Hide resolved
...ava/org/prebid/server/hooks/modules/greenbids/real/time/data/model/data/GreenbidsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
previously approved these changes
Jan 27, 2025
9 tasks
142554d
to
e6a10a8
Compare
CTMBNara
requested changes
Jan 29, 2025
...ks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
...ks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
...ks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
approved these changes
Feb 3, 2025
CTMBNara
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
As discussed with @bretg and @jbogp we need to add extraction of modules params from account level config for both RTD module and analytics reporter. At the same time if the params are defined in
BidRequestExt
it should take precedent before account level config. This makes modules integration more publisher friendly🧠 Rationale behind the change
account/id
identifies account for specific publisher -> so if we define a config for a specific account it means it should correspond to the unique publisher id = pbuid.Setup of
default-account-config
for Greenbids example inprebid-config-with-module.yaml
should look like thisThe modules can extract fields of Account class from AuctionContext at hook call (not on spring boot)
Then depending on the calling module we get analytics or RTD
Map[String, ObjectNode] modules
and parse it from json.🔎 New Bid Adapter Checklist
🧪 Test plan
I have introduced a specific test case in Greenbids analytics reporter test to fallback to account level config if bid request ext config is not defined:
shouldReceiveValidResponseAndFallbackToAccountLevelConfigWhenPartnerNotActivatedInBidRequest
For RTD module have modified the existing test case when partner not activated on bid request ext -> then fallback to account level config and proceed with the filtering
callShouldFilterBiddersAndFallbackToAccountLevelConfigWhenPartnerNotActivatedInBidRequest
🏎 Quality check