Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default number for tests.max-container-count #3518

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Increase default number for tests.max-container-count #3518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a06885
Increase default number for `tests.max-container-count`
osulzhenko Oct 18, 2024
543312f
Merge branch 'refs/heads/master' into increase-default-number
osulzhenko Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/developers/functional-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Functional tests need to have name template **.\*Spec.groovy**
**Properties:**

`launchContainers` - responsible for starting the MockServer and the MySQLContainer container. Default value is false to not launch containers for unit tests.
`tests.max-container-count` - maximum number of simultaneously running PBS containers. Default value is 2.
`tests.max-container-count` - maximum number of simultaneously running PBS containers. Default value is 5.
`skipFunctionalTests` - allow to skip funtional tests. Default value is false.
`skipUnitTests` - allow to skip unit tests. Default value is false.

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@
<systemPropertyVariables>
<mockserver.version>${mockserver.version}</mockserver.version>
<pbs.version>${project.version}</pbs.version>
<tests.max-container-count>2</tests.max-container-count>
<tests.max-container-count>5</tests.max-container-count>
<tests.fixed-container-ports>false</tests.fixed-container-ports>
</systemPropertyVariables>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion src/test/groovy/org/prebid/server/functional/testcontainers/PbsServiceFactory.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@ class PbsServiceFactory {
private static int getMaxContainerCount() {
USE_FIXED_CONTAINER_PORTS
? 1
: SystemProperties.getPropertyOrDefault("tests.max-container-count", 2)
: SystemProperties.getPropertyOrDefault("tests.max-container-count", 5)
}
}
Loading