Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TypeScript typings #251

Merged
merged 1 commit into from
Aug 1, 2016
Merged

add TypeScript typings #251

merged 1 commit into from
Aug 1, 2016

Conversation

kruczy
Copy link
Contributor

@kruczy kruczy commented Aug 1, 2016

No description provided.

@developit
Copy link
Member

Build error is just a saucelabs issue, ignore it. Thanks for this!

@developit developit merged commit 5b0e1d7 into preactjs:master Aug 1, 2016
@jmarsh999
Copy link
Contributor

Just a quick issue with the typings definition for linkState. Currently it is defined to return a void, but in reality it should return a function:
linkState:(name:string) => (e: Event)=>void;

@developit
Copy link
Member

Correct! Want to PR?

@jmarsh999
Copy link
Contributor

Sure, the PR has been submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants