Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed from open() to io.open() #378

Merged
merged 4 commits into from
Apr 21, 2019
Merged

Changed from open() to io.open() #378

merged 4 commits into from
Apr 21, 2019

Conversation

roottool
Copy link

@roottool roottool commented Apr 21, 2019 •
edited by asottile
Loading

Issue number

Resolves #377

Description

This PR changes a function in pre_commit_hooks/check_yaml.py from open() to io.open().

asottile
asottile approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@asottile
Copy link
Member

oops, looks like if you pre-commit run --all-files locally that'll fix up the import ordering 👍

@roottool
Copy link
Author

Thank you for the advice.
All checks have passed after I fixed the position of import io.

@asottile asottile merged commit f677478 into pre-commit:master Apr 21, 2019
@asottile
Copy link
Member

Thanks for the contribution! 🎉

@roottool roottool deleted the change-from-open-to-io.open#377 branch April 21, 2019 19:38
@roottool roottool mentioned this pull request Apr 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check Yaml has occurred an error on Windows by open() function
2 participants
@roottool @asottile