Report failing filenames when --fix=no in mixed-line-endings #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Nov 26, 2018
|
looks good -- now all that's left is to add a quick test for this and it should be good to merge! You'll find the |
|
@gimbo let me know if you want some help writing the test :) |
|
@asottile Thanks, it's not really a matter of needing help, it's more about time/other commitments. I may get to it; if someone else gets to it before me, great. |
|
🎉 thanks for the PR @gimbo -- I added some quick lines to test the new output and it looks good! |
|
Thanks @asottile - that's great! Sorry I wasn't able to close the loop on this one but other work got frantic all of a sudden. :-) |
|
No problem! Happy to push this the last mile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 340.