Provide automatic removal of pkg-resources==0.0.0 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help to deal with that pretty paintuly issue under Ubuntu/Debian family: https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463
asottile
reviewed
Mar 25, 2018
| @@ -69,6 +69,11 @@ def fix_requirements(f): | |||
| else: | |||
| rest = [] | |||
|
|
|||
| for requirement in requirements: | |||
| if b'pkg-resources' in requirement.name: | |||
| if b'0.0.0' in requirement.value: | |||
There was a problem hiding this comment.
I think this makes more sense?
if requirement.value == b'pkg-resources==0.0.0\n':
...
|
Otherwise looks good, shame debian botched the metadata here :( |
asottile
reviewed
Mar 25, 2018
| if b'0.0.0' in requirement.value: | ||
| requirements.remove(requirement) | ||
| if requirement.value == b'pkg-resources==0.0.0\n': | ||
| requirements.remove(requirement) |
There was a problem hiding this comment.
actually, now that I look at it I think this loop results in UB (modifying list while iterating over it) -- you can avoid this with:
requirements = [
requirement for requirement in requirements
if requirement.value != b'pkg-resources==0.0.0\n'
]
asottile
approved these changes
Mar 25, 2018
Forgot to rename one var...
nvtkaszpir
force-pushed
the
feature/fix-broken-pkg-resources
branch
from
b6bdda5 to
980fc9b
Compare
|
Thanks for the feature! |
|
Thanks for the comments. Looking at it now all those comments and CI failures ... it's a sign I should go to sleep ;) |
|
This has been (finally!) released as part of v1.3.0! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help to deal with that pretty paintuly issue under Ubuntu/Debian
family:
https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463