Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional bug with 0 requests remaining and 0 seconds before reset #192

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

bboe
Copy link
Member

@bboe bboe commented Jan 25, 2025

Additionally, replace uses of time.time with time.monotonic or time.monotonic_ns.

@bboe bboe merged commit 8cbb684 into main Jan 25, 2025
28 checks passed
@bboe bboe deleted the last_request branch January 25, 2025 06:52
@LilSpazJoekp
Copy link
Member

This might be a breaking change. There's a method in PRAW that returns the current rate limits.

@bboe
Copy link
Member Author

bboe commented Jan 25, 2025

Yes, this bump will be considered a breaking change and will necessitate a corresponding major release of PRAW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants