Issue 55: Support for Json schema draft 4 to 7 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivesh Ranjan <[email protected]>
Signed-off-by: Shivesh Ranjan <[email protected]>
ravisharda
suggested changes
Jul 17, 2020
server/src/main/java/io/pravega/schemaregistry/service/SchemaRegistryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivesh Ranjan <[email protected]>
ravisharda
suggested changes
Jul 17, 2020
server/src/main/java/io/pravega/schemaregistry/service/SchemaRegistryService.java
Show resolved
Hide resolved
server/src/main/java/io/pravega/schemaregistry/service/SchemaRegistryService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/pravega/schemaregistry/service/SchemaRegistryService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/pravega/schemaregistry/service/SchemaRegistryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivesh Ranjan <[email protected]>
Signed-off-by: Shivesh Ranjan <[email protected]>
Signed-off-by: Shivesh Ranjan <[email protected]>
ravisharda
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivesh Ranjan [email protected]
Change log description
Use everit.json.SchemaLoader to parse the json schema to verify that it is supported for schemas that follow draft specifications from 4 6 or 7.
Purpose of the change
Fixes #55
What the code does
Jackson's JsonSchema module supports Json schema draft 3. Draft 4 to 7 have some additional incompatible changes. JsonSchema is not able to parse a schema which conforms to versions 4 to 7 if they use any keywords that is not present in draft 3.
So we first try to parse the schema using JsonSchema and if it fails, we attempt to parse it using SchemaLoader.
If both fail, the schema is considered invalid.
How to verify it
TBD