Issue 245: Async token refresh #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
shrids
reviewed
May 3, 2021
added 2 commits
May 3, 2021 00:29
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 78.47% 78.38% -0.09%
==========================================
Files 51 51
Lines 10412 10541 +129
==========================================
+ Hits 8171 8263 +92
- Misses 2241 2278 +37
|
shrids
reviewed
May 3, 2021
shrids
approved these changes
May 3, 2021
added 4 commits
May 3, 2021 10:25
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
shrids
reviewed
May 5, 2021
| self.stream | ||
| .as_mut() | ||
| .expect("get connection") | ||
| .flush() |
There was a problem hiding this comment.
This API Flushes this stream, ensuring that all intermediately buffered contents reach their destination.
https://docs.rs/tokio-rustls/0.22.0/src/tokio_rustls/client.rs.html#93-94 snippet indicates a TlsStream.flush() is required to ensure data actually reaches the destination.
Is this different with a TcpStream ?
There was a problem hiding this comment.
yeah I think TcpStream itself doesn't have a buffer and any write is directly sent over the wire. However this TlsStream has a buffer inside that needs to be flushed. The name TlsStream is kind of misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Currently token refresh is using a Runtime which makes it impossible to work in a async context. Use async way to refresh the token instead.
Purpose of the change
Fix #245
What the code does
Use async way to refresh token