-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 241: Reorg code #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
tkaitchuck
approved these changes
May 7, 2021
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 78.38% 77.57% -0.82%
==========================================
Files 51 44 -7
Lines 10541 10323 -218
==========================================
- Hits 8263 8008 -255
- Misses 2278 2315 +37
|
Signed-off-by: Wenqi Mou <[email protected]>
shrids
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Reorg the code.
raw_client
,segment_metadata
,segment_selector
,reactor
,segment_writer
to a new modulesegment
and removesegment
prefix in their names.event_stream_writer
,event_reader
,reader_group
related files andtransaction
module into a new module 'event'.bytestream
to a new modulebyte
.synchronizer
,tablemap
to a new modulesync
.trace
,metric
to a new moduleutil
.error
file and move individual error into related files.event_stream_writer
toevent_writer
.transactional_event_stream_writer
totransaction_event_writer
.byte_stream_writer
andbyte_stream_reader
tobyte_writer
andbyte_reader
.table_synchronizer
tosynchronizer
.Purpose of the change
Fix #241 #246 #240
What the code does
How to verify it
Tests should pass