Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approve after #104 - 105 step size is not passed to optimizer in modular attack #107

Merged

Conversation

maurapintor
Copy link
Collaborator

@maurapintor maurapintor commented Oct 10, 2024

Changelog

Approve after #104

  • Pass input learning rate to optimizer
  • Refactor input optimizer kwargs for modular attack to be explicitly assigned to a dictionary rather than passed implicitly

Fixes #105, #106.


📚 Documentation preview 📚: https://secml-torch--107.org.readthedocs.build/en/107/

@maurapintor maurapintor added bug Something isn't working enhancement New feature or request refactoring Improvements that don't add or modify functionalities. labels Oct 10, 2024
@maurapintor maurapintor self-assigned this Oct 10, 2024
@maurapintor maurapintor linked an issue Oct 10, 2024 that may be closed by this pull request
@maurapintor maurapintor requested a review from zangobot October 10, 2024 12:28
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (674b2bc) to head (3abd378).

Files with missing lines Patch % Lines
src/secmlt/optimization/constraints.py 91.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   90.79%   90.89%   +0.10%     
==========================================
  Files          49       49              
  Lines        1314     1351      +37     
==========================================
+ Hits         1193     1228      +35     
- Misses        121      123       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurapintor maurapintor changed the title 105 step size is not passed to optimizer in modular attack approve after #104 - 105 step size is not passed to optimizer in modular attack Oct 10, 2024
Copy link
Contributor

@zangobot zangobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zangobot zangobot merged commit 847942f into main Oct 14, 2024
10 checks passed
@maurapintor maurapintor deleted the 105-step-size-is-not-passed-to-optimizer-in-modular-attack branch October 22, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request refactoring Improvements that don't add or modify functionalities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step size is not passed to optimizer in modular attack
2 participants